| Conditions | 22 |
| Paths | 1536 |
| Total Lines | 54 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like index.js ➔ on_key often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | var times = 0; |
||
| 10 | { |
||
| 11 | var marquee = $('<marquee/>', {behavior: 'slide', direction: 'left', id: 'konami'}); |
||
| 12 | var img = $('<img/>', {src: '/img/common/logo.svg'}); |
||
| 13 | if(times >= 1) |
||
| 14 | { |
||
| 15 | marquee.append("Here we go again..."); |
||
| 16 | } |
||
| 17 | img.appendTo(marquee); |
||
| 18 | var audio = $('<audio/>', {autoplay: true}); |
||
| 19 | $('<source/>', {src: '/media/contra.ogg', type: 'audio/ogg'}).appendTo(audio); |
||
| 20 | audio.appendTo(marquee); |
||
| 21 | marquee.appendTo($('#content')); |
||
| 22 | setTimeout(clear_konami, 5000); |
||
| 23 | } |
||
| 24 | |||
| 25 | function pageInit() |
||
| 26 | { |
||
| 27 | cheet('up up down down left right left right b a', konami); |
||
| 28 | } |
||
| 29 | |||
| 30 | $(pageInit); |
||
| 31 |